8000 feat(content-blog): Allow pagination for BlogTagsPostsPage by redhoyasa · Pull Request #6221 · facebook/docusaurus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(content-blog): Allow pagination for BlogTagsPostsPage #6221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Feb 3, 2022
Merged

feat(content-blog): Allow pagination for BlogTagsPostsPage #6221

merged 13 commits into from
Feb 3, 2022

Conversation

redhoyasa
Copy link
Contributor
@redhoyasa redhoyasa commented Dec 29, 2021 •
edited
Loading

todo:

  • Map blogTagsPostListPaginated to BlogTagsPostsPage props
  • Add pagination to BlogTagsPostsPage
  • Make sure BlogTagsListPage shows the correct number of posts under tags.
  • Tests
  • Refactor if needed

Motivation

Fix #6182.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Test the pagination with postsPerPage: 1 and with recap tag in the generated Docusaurus 2 Website.

Related PRs

N/A

@facebook-github-bot
Copy link
Contributor

Hi @redhoyasa!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link
netlify bot commented Dec 29, 2021 •
edited
Loading

✔️ [V2]

🔨 Explore the source changes: a398b2c

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61fc0e155ad4ff0008cca3e0

😎 Browse the preview: https://deploy-preview-6221--docusaurus-2.netlify.app

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 29, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@Josh-Cena Josh-Cena added the pr: new feature This PR adds a new API or behavior. label Dec 29, 2021
Josh-Cena
Josh-Cena reviewed Dec 31, 2021
View reviewed changes
@github-actions
Copy link
github-actions bot commented Dec 31, 2021 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 47
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 92

Lighthouse ran on https://deploy-preview-6221--docusaurus-2.netlify.app/

@redhoyasa redhoyasa marked this pull request as ready for review January 1, 2022 18:17
@slorber
Copy link
Collaborator
slorber commented Jan 5, 2022

Test the pagination with postsPerPage: 1 and with recap tag in the generated Docusaurus 2 Website.

Can you please temporarily add these settings and link to the relevant review page in the issue description? This way we'll be able to review easily without having to run locally

@redhoyasa
Copy link
Contributor Author

@slorber sure, I've adjusted the settings.

@KELEN
Copy link
KELEN commented Feb 3, 2022

@slorber sure, I've adjusted the settings.
I'm happy to use this feature.
I want to know if you have finished the settings. Thank's a lot

slorber
slorber approved these changes Feb 3, 2022
View reviewed changes
Copy link
Collaborator
@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 👍

Made some needed refactors that I want to do for a while + deduplicated some pagination logic between blog posts and tags

@slorber slorber merged commit 48f080e into facebook:main Feb 3, 2022
@heowc heowc mentioned this pull request Mar 15, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6F1B
Reviewers

@Josh-Cena Josh-Cena Josh-Cena left review comments

@slorber slorber slorber approved these changes

@lex111 lex111 Awaiting requested review from lex111

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow pagination for BlogTagsPostsPage
5 participants
@redhoyasa @facebook-github-bot @slorber @KELEN @Josh-Cena
0