8000 Make {un,}border work on views and layer expressions by kastiglione · Pull Request #1 · facebook/chisel · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make {un,}border work on views and layer expressions #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 5, 2014
Merged

Make {un,}border work on views and layer expressions #1

merged 2 commits into from
Mar 5, 2014

Conversation

kastiglione
Copy link
Contributor

This does the following:

  1. Documents the type of the viewOrLayer argument.
  2. Uses the recently added convertToLayer function to actually allow border to be called with either a view or a layer.

@dstnbrkr
Copy link
Contributor
dstnbrkr commented Mar 5, 2014

+1

arigrant added a commit that referenced this pull request Mar 5, 2014
@arigrant
Merge pull request #1 from facebook/border-duality
e7e15b3 
Make {un,}border work on views and layer expressions
@arigrant arigrant merged commit e7e15b3 into master Mar 5, 2014
@kastiglione kastiglione deleted the border-duality branch March 5, 2014 23:44
kastiglione pushed a commit that referenced this pull request Jan 1, 2016
@longv2go
Merge pull request #1 from facebook/master
52c8500 
Merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@arigrant arigrant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kastiglione @dstnbrkr @arigrant
0