8000 Add additional functions and fix function call errors by travoltron · Pull Request #1033 · fzaninotto/Faker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Dec 11, 2020. It is now read-only.

Add additional functions and fix function call errors #1033

Closed
wants to merge 1 commit into from

Conversation

travoltron
Copy link

Calling other functions besides 'sqrt' never worked in application, possibly because I'm on php7. I modified this file and added a couple additional biasing methods to the mix, namely 'square' and 'cube'.

@fzaninotto
Copy link
Owner

The $function parameter isn't a function name, but a function value. You're breaking the API, si I can't accept that PR. If there is a bug on PHP7, I'd welcome a bugfix PR.

@fzaninotto fzaninotto closed this Sep 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0