Validate create asset response. #1981
Conversation
| return r.validateAssetResponse(responseJSON, taxonomyFile, datasetID) | ||
| } | ||
|
|
||
| func (r *FybrikApplicationReconciler) ValidateCreateAssetResponse(response *datacatalog.CreateAssetResponse, |
There was a problem hiding this comment.
The functions are pretty much identical, we don't need both. Just pass interface{} as the argument.
There was a problem hiding this comment.
@shlomitk1 ok, Thanks
There was a problem hiding this comment.
No, the function will already get the right taxonomy, as you implemented. I suggest merely to change the function signature and then you'll be able to call the same function with different taxonomy file.
There was a problem hiding this comment.
@shlomitk1 Thanks please take a look at the changes. (I overwrite the previous commits) Thanks
| @@ -21,7 +21,7 @@ import ( | |||
| // - an error if happened | |||
| // - the new asset identifier | |||
| func (r *FybrikApplicationReconciler) RegisterAsset(assetID string, catalogID string, | |||
| info *fapp.DatasetDetails, input *fapp.FybrikApplication) (string, error) { | |||
| info *fapp.DatasetDetails, input *fapp.FybrikApplication) (*datacatalog.CreateAssetResponse, error) { | |||
There was a problem hiding this comment.
Why are you changing the signature? The original behavior was to register the asset and return the registered asset id or an error. Why not do the validation here and return the same after validation.
There was a problem hiding this comment.
I'll do that Thanks
| if err != nil { | ||
| applicationContext.Log.Error().Err(err).Msg("failed to validate the catalog connector " + | ||
| "response when creating new asset") | ||
| setReadyCondition(applicationContext, assetID) |
There was a problem hiding this comment.
We could not properly register the asset. Why is it ready?
There was a problem hiding this comment.
I'll fix that thanks
Signed-off-by: Revital Sur <eres@il.ibm.com>
This PR adds a missing taxonomy verification of the create asset response.