Bump helm.sh/helm/v3 from 3.10.3 to 3.11.1 #1968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
shlomitk1
reviewed
Feb 9, 2023
| k8s.io/api v0.26.0 | ||
| k8s.io/apimachinery v0.26.0 | ||
| k8s.io/cli-runtime v0.26.0 | ||
| k8s.io/client-go v0.26.0 |
There was a problem hiding this comment.
Why do you require 0.26 and then replace with 0.25?
There was a problem hiding this comment.
I don't require 0.26 it go mod tidy includes it.
However, with 0.26, we get
# sigs.k8s.io/controller-runtime/pkg/cache
/Users/alexey/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.2/pkg/cache/informer_cache.go:144:9: cannot use i.Informer (variable of type "k8s.io/client-go/tools/cache".SharedIndexInformer) as type Informer in return statement:
"k8s.io/client-go/tools/cache".SharedIndexInformer does not implement Informer (wrong type for AddEventHandler method)
have AddEventHandler(handler "k8s.io/client-go/tools/cache".ResourceEventHandler) ("k8s.io/client-go/tools/cache".ResourceEventHandlerRegistration, error)
want AddEventHandler(handler "k8s.io/client-go/tools/cache".ResourceEventHandler)
/Users/alexey/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.2/pkg/cache/informer_cache.go:158:9: cannot use i.Informer (variable of type "k8s.io/client-go/tools/cache".SharedIndexInformer) as type Informer in return statement:
"k8s.io/client-go/tools/cache".SharedIndexInformer does not implement Informer (wrong type for AddEventHandler method)
have AddEventHandler(handler "k8s.io/client-go/tools/cache".ResourceEventHandler) ("k8s.io/client-go/tools/cache".ResourceEventHandlerRegistration, error)
want AddEventHandler(handler "k8s.io/client-go/tools/cache".ResourceEventHandler)
will return to the issue later
shlomitk1
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve a moderate severity Dependabot alert on = helm.sh/helm/v3.
Bumps helm.sh/helm/v3 from 3.10.3 to 3.11.1.
Doesn't promote K8s to 0.26.0
Instead of #1967
Signed-off-by: Alexey Roytman roytman@il.ibm.com