Fixes install_or_tools.sh #1911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
zivnevo
previously approved these changes
Jan 19, 2023
OK Co-authored-by: Ziv Nevo <79099626+zivnevo@users.noreply.github.com>
of course. Co-authored-by: Ziv Nevo <79099626+zivnevo@users.noreply.github.com>
shlomitk1
previously approved these changes
Jan 19, 2023
zivnevo
previously approved these changes
Jan 19, 2023
shlomitk1
reviewed
Jan 19, 2023
|
TODO check with @ngoracke why tools are installed on Ubunty, but run on Centos |
shlomitk1
approved these changes
Jan 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
install_or_tools.shscript runs, it checks that the bin/fzn-or-tools and lib/libfz.so files exist.However, on MAC there is no lib/libfz.so file, and as a result, the script always installs the tool.
In addition, it doesn't check the installed version
/fixes #1909
Signed-off-by: Alexey Roytman roytman@il.ibm.com