10000 Control testing verbosity option by shlomitk1 · Pull Request #1904 · fybrik/fybrik · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Control testing verbosity option #1904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 19, 2023
Merged

Conversation

shlomitk1
Copy link
Contributor

Signed-off-by: Shlomit Koyfman shlomitk@il.ibm.com
Fixes #1861

Set TEST_VERBOSITY to 1 in order to get tests with full verbosity, by default, it's 0.
Details will be printed only for failing tests.

Signed-off-by: Shlomit Koyfman <shlomitk@il.ibm.com>
@shlomitk1 shlomitk1 marked this pull request as ready for review January 18, 2023 07:19
@shlomitk1 shlomitk1 requested a review from revit13 January 18, 2023 07:19
@@ -3,7 +3,7 @@ include $(ROOT_DIR)/Makefile.env

.PHONY: test
test: *.go
go test -v
go test $(TEST_OPTIONS)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add $(TEST_OPTIOS) to the line 15 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@shlomitk1 shlomitk1 merged commit e5769bf into fybrik:master Jan 19, 2023
@shlomitk1 shlomitk1 deleted the verbosity-in-tests branch January 19, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Difficult to understand if Fybrik tests pass
3 participants
0