8000 A skeleton for handling multiple implementations of storage allocation/deletion based on the storage type by shlomitk1 · Pull Request #1868 · fybrik/fybrik · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

A skeleton for handling multiple implementations of storage allocation/deletion based on the storage type #1868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement 8000 . We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 17 commits into from
Closed

A skeleton for handling multiple implementations of storage allocation/deletion based on the storage type #1868

wants to merge 17 commits into from

Conversation

shlomitk1
Copy link
Contributor
@shlomitk1 shlomitk1 commented Jan 4, 2023 •
edited
Loading

This PR is based on #1855
It closes #1851
Implementation is based on https://github.com/fybrik/fybrik/blob/master/docs/StorageManagement.md#architecture
Added files:

  • pkg/storage/registrator/agent/agent.go
  • pkg/storage/registrator/registrator.go
  • pkg/storage/storage_manager.go
  • pkg/storage/storage_manager_test.go
  • pkg/storage/impl/mysql/mysql_impl.go
  • pkg/storage/impl/s3/s3_impl.go

This PR does not change the existing implementation of storage management in Fybrik because the added storage_manager is not integrated with Fybrik (yet). It demonstrates how the various storage types can be added in order to implement AllocateStorage, DeleteStorage, GetSupportedConnectionTypes functionality of StorageManager by registering placeholder implementations for S3 and MySQL.
Future PRs will replace the placeholder for S3 with actual implementation, define REST APIs, integrate StorageManager with Fybrik, etc.

@shlomitk1
add storageaccount type
9ece1c2 
Signed-off-by: Shlomit Koyfman <shlomitk@il.ibm.com>
@shlomitk1
proper serialization/deserialization
6a21762 
Signed-off-by: Shlomit Koyfman <shlomitk@il.ibm.com>
@shlomitk1
Merge branch 'master' into sa-crd
c41ce6d
@shlomitk1
Merge remote-tracking branch 'upstream/master' into sa-crd
f28981b
@shlomitk1
Merge branch 'master' into sa-crd
15b218c
@shlomitk1
Merge branch 'sa-crd' of https://github.com/shlomitk1/the-mesh-for-data…
c630a22 
… into sa-crd
@shlomitk1
upgrade tools
eee4c96 
Signed-off-by: Shlomit Koyfman <shlomitk@il.ibm.com>
@shlomitk1
fix auto-generated files
c6c2590 
Signed-off-by: Shlomit Koyfman <shlomitk@il.ibm.com>
@shlomitk1
revert last change
0c8ec80 
Signed-off-by: Shlomit Koyfman <shlomitk@il.ibm.com>
@shlomitk1
skeleton for managing several implementations for storage management …
42fda7d 
…based on storage type

Signed-off-by: Shlomit Koyfman <shlomitk@il.ibm.com>
@shlomitk1
licenses
d0750b4 
Signed-off-by: Shlomit Koyfman <shlomitk@il.ibm.com>
@shlomitk1
lint issues
3d0d568 
Signed-off-by: Shlomit Koyfman <shlomitk@il.ibm.com>
@shlomitk1
lints
34c9023 
Signed-off-by: Shlomit Koyfman <shlomitk@il.ibm.com>
@shlomitk1
more lint issues
f54b232 
Signed-off-by: Shlomit Koyfman <shlomitk@il.ibm.com>
@shlomitk1 shlomitk1 marked this pull request as ready for review January 4, 2023 12:49
@shlomitk1 shlomitk1 requested a review from roytman January 4, 2023 12:50
@shlomitk1 shlomitk1 marked this pull request as draft January 12, 2023 07:43
@shlomitk1 shlomitk1 closed this Jan 12, 2023
@shlomitk1 shlomitk1 deleted the storage-manager branch January 12, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roytman roytman Awaiting requested review from roytman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create skeleton for supporting multiple connection types in StorageManager
1 participant
@shlomitk1
0