8000 Storage management design by shlomitk1 · Pull Request #1837 · fybrik/fybrik · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

Storage management design #1837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 18, 2022
Merged

Conversation

shlomitk1
Copy link
Contributor

Signed-off-by: Shlomit Koyfman shlomitk@il.ibm.com
HLD of storage management in Fybrik

Signed-off-by: Shlomit Koyfman <shlomitk@il.ibm.com>
Signed-off-by: Shlomit Koyfman <shlomitk@il.ibm.com>
Signed-off-by: Shlomit Koyfman <shlomitk@il.ibm.com>
Copy link
Member
@simanadler simanadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress!

@simanadler
Copy link
Member

Today datashim is not installed as part of the fybrik installation. Shouldn't any dependencies of the storage manager should be installed together with the control plane?

@shlomitk1
Copy link
Contributor Author

Today datashim is not installed as part of the fybrik installation. Shouldn't any dependencies of the storage manager should be installed together with the control plane?

It does not have dependencies. The only question is whether to deploy it always or not (based on enabled flag), and we decided to deploy it always.

Signed-off-by: Shlomit Koyfman <shlomitk@il.ibm.com>
Signed-off-by: Shlomit Koyfman <shlomitk@il.ibm.com>
- IT config policies for configuration options

### Phase4

8000 Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you separate support connection types and storage types? Should they be implemented together ?


- A single connection taxonomy should be used by modules, catalog conector and storage manager.

- Deployment of FybrikStorageAccount CRD should be configurable - to be discussed: [issue 1717](https://github.com/fybrik/fybrik/issues/1717)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If FybrikStorageAccount is not deployed, does it mean that the Storage Manager will not been deployed too? Should we support optional deployment of the Storage Manager?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional deployment of StorageManager is equivalent to optional deployment of FybrikStorageAccount CRD, there is no meaning of deploying one without another. In this design both are deployed unconditionally.

Signed-off-by: Shlomit Koyfman <shlomitk@il.ibm.com>
simanadler
simanadler previously approved these changes Dec 11, 2022
Signed-off-by: Shlomit Koyfman <shlomitk@il.ibm.com>
@shlomitk1 shlomitk1 merged commit e32d60b into fybrik:master Dec 18, 2022
@shlomitk1 shlomitk1 deleted the storage-management-design branch December 18, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0