Preserve logging format in manager #1697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomit Koyfman <shlomitk@il.ibm.com>
roytman
reviewed
Aug 19, 2022
There was a problem hiding this comment.
Still there are messages like
I0819 15:44:00.708146 1 request.go:665] Waited for 1.136695625s due to client-side throttling, not priority and fairness, request: GET:https://10.96.0.1:443/apis/policy/v1beta1?timeout=32s
I0819 15:44:23.037100 1 leaderelection.go:258] successfully acquired lease fybrik-system/fybrik-operator-leader-election
maybe it's hard to eliminate them completely
The biggest issue here that you wrong the Caller tag.
in the fybrik messages, the caller (lower case) is the file name and line where the message was generated.
{"level":"trace","Setup":"main","local charts dir":"","time":"2022-08-19T15:44:04Z","caller":"/Users/alexey/goWork/src/github.com/fybrik/fybrik/manager/main.go:222","message":"creating Blueprint controller"}```
in the new logger Caller is like "callerType" in the fybrik logger.
{"level":"info","reconciler group":"app.fybrik.io","reconciler kind":"FybrikModule","Caller":"controller.fybrikmodule","time":"2022-08-19T15:44:23Z","message":"Starting Controller"}
maybe rename it to CallerType ?
can we print the file/line of the caller ?
Signed-off-by: Shlomit Koyfman <shlomitk@il.ibm.com>
|
Set the new logger for klog as well, this will take care of logging done in internal packages that ignore the manager log. |
Signed-off-by: Shlomit Koyfman <shlomitk@il.ibm.com>
roytman
reviewed
Aug 21, 2022
pkg/logging/writer.go
Outdated
| for key, val := range values { | ||
| l = l.Str(key, val) | ||
| } | ||
| l.Msg(msg) |
Signed-off-by: Shlomit Koyfman <shlomitk@il.ibm.com>
roytman
approved these changes
Aug 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shlomit Koyfman shlomitk@il.ibm.com
Fixes #1399
This PR changes the logging format of controller-runtime packages from
2022-03-31T08:02:54.666Z INFO controller-runtime.webhook serving webhook server {"host": "", "port": 9443}to
{"level":"info","Caller":"controller-runtime.webhook","host":"","port":"9443","time":"2022-08-17T14:23:24Z","message":"Serving webhook server"}