Remove the property creationTimestamp from the yaml file of the CRDs #1688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roytman
reviewed
Aug 11, 2022
Makefile
Outdated
| $(TOOLBIN)/controller-gen webhook paths=./manager/apis/... output:stdout | \ | ||
| $(TOOLBIN)/yq eval '.metadata.annotations."cert-manager.io/inject-ca-from" |= "{{ .Release.Namespace }}/serving-cert"' - | \ | ||
| $(TOOLBIN)/yq eval '.metadata.annotations."certmanager.k8s.io/inject-ca-from" |= "{{ .Release.Namespace }}/serving-cert"' - | \ | ||
| $(TOOLBIN)/yq eval '(.metadata.name | select(. == "mutating-webhook-configuration")) = "{{ .Release.Namespace }}-mutating-webhook"' - | \ | ||
| $(TOOLBIN)/yq eval '(.metadata.name | select(. == "validating-webhook-configuration")) = "{{ .Release.Namespace }}-validating-webhook"' - | \ | ||
| $(TOOLBIN)/yq eval '(.webhooks.[].clientConfig.service.namespace) = "{{ .Release.Namespace }}"' - > charts/fybrik/files/webhook-configs.yaml | ||
| $(TOOLBIN)/yq eval -i 'del(.metadata.creationTimestamp)' charts/fybrik/files/webhook-configs.yaml |
There was a problem hiding this comment.
you can do it as a part of previous command.
Can we add kubeval as part of the manifest command ?
roytman
reviewed
Aug 14, 2022
roytman
reviewed
Aug 14, 2022
d65325e to
24c94fb
Compare
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: mohammad-nassar10 <mohammad.nassar@ibm.com>
Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
4fce2af to
2a6c939
Compare
revit13
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.