8000 ⚠️ Set go version to 1.18 by ityuhui · Pull Request #1667 · fybrik/fybrik · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

⚠️ Set go version to 1.18 #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
8000
Merged
merged 1 commit into from
Jan 3, 2023
Merged

⚠️ Set go version to 1.18 #1667

merged 1 commit into from
Jan 3, 2023

Conversation

ityuhui
Copy link
Contributor
@ityuhui ityuhui commented Aug 4, 2022

Fixes #1664

Signed-off-by: Hui Yu ityuhui@gmail.com

@ityuhui ityuhui changed the title Set go version to 1.18 [WIP] Set go version to 1.18 Aug 5, 2022
@ityuhui
Copy link
Contributor Author
ityuhui commented Aug 8, 2022 •
edited
Loading 
go fix ./...
Error: connectors/katalog/pkg/apis/katalog/v1alpha1/zz_generated.deepcopy.go: fixed buildtag
Error: manager/apis/app/v1beta1/zz_generated.deepcopy.go: fixed buildtag
Error: pkg/model/attributes/zz_generated.deepcopy.go: fixed buildtag
Error: pkg/model/datacatalog/zz_generated.deepcopy.go: fixed buildtag
Error: pkg/model/policymanager/zz_generated.deepcopy.go: fixed buildtag
Error: pkg/model/taxonomy/zz_generated.deepcopy.go: fixed buildtag

The reason for the above failure is:

controller-gen used by Fybirk is built by go v1.17, it will generates the *.deepcopy.go with the old build tag comment:

// +build !ignore_autogenerated

But during the make verify, the go fmt, go fix in go v1.18 will replace them with the new comment:

//go:build !ignore_autogenerated

Which causes the check failures.

The controller-tools community does not plan to bump golang to 1.18 recently.
kubernetes-sigs/controller-tools#674

So we cannot fix this issue now.

Can we disable the check of go fix ?

fybrik/hack/make-rules/verify.mk

Lines 26 to 29 in f6a5e4a

CODE_MAINT += vet
.PHONY: vet
vet:
go vet ./...

@roytman
Copy link
Collaborator
roytman commented Aug 8, 2022

Hi @ityuhui, thanks for the investigation, let me check what can we do.

@ityuhui
Copy link
Contributor Author
ityuhui commented Dec 6, 2022

Hi @roytman

How about this issue ? A number of Go1.17 vulnerabilities have been reported recently. We need to upgrade it.

@roytman
Copy link
Collaborator
roytman commented Dec 6, 2022

Hi @roytman

How about this issue ? A number of Go1.17 vulnerabilities have been reported recently. We need to upgrade it.

Hi @ityuhui, we'll check it

@roytman
Copy link
Collaborator
roytman commented Jan 1, 2023

Hi @ityuhui, sorry for the late response (I had a long vacation).
Can you please resolve the conflicts and rebase the PR.
Now, in order to fix the validation, could you please add the go fix ./... command as the last command in the make generate rule. after the line

fybrik/Makefile

Line 35 in c20ee72

$(TOOLBIN)/controller-gen object:headerFile=./hack/boilerplate.go.txt,year=$(shell date +%Y) paths="./..."

@ityuhui
Copy link
Contributor Author
ityuhui commented Jan 2, 2023

Sure. I'll do it.

@ityuhui
Set go version to 1.18
c2b7719 
Signed-off-by: Hui Yu <ityuhui@gmail.com>
@ityuhui ityuhui changed the title [WIP] Set go version to 1.18 Set go version to 1.18 Jan 3, 2023
@ityuhui
Copy link
Contributor Author
ityuhui commented Jan 3, 2023

Hi @roytman

All checks pass now. Can you please review the latest PR ?

@roytman roytman merged commit 9eb008d into fybrik:master Jan 3, 2023
@roytman
Copy link
Collaborator
roytman commented Jan 3, 2023

@ityuhui, thanks for the PR.

@ityuhui ityuhui deleted the yh-go-version-upgrade-0704 branch January 3, 2023 03:43
@roytman roytman changed the title Set go version to 1.18 warning: Set go version to 1.18 Jan 5, 2023
@roytman roytman changed the title warning: Set go version to 1.18 Note: Set go version to 1.18 Jan 5, 2023
@roytman roytman changed the title Note: Set go version to 1.18 :warning Set go version to 1.18 Jan 5, 2023
@roytman roytman changed the title :warning Set go version to 1.18 ⚠️ Set go version to 1.18 Jan 5, 2023
@revit13
Copy link
Collaborator
revit13 commented Jan 15, 2023 •
edited by fybrik-bot bot
Loading

/cherry-pick branch=releases/1.2.1

Failed - see https://github.com/fybrik/fybrik/actions/runs/3922817307

revit13 pushed a commit to revit13/fybrik that referenced this pull request Jan 15, 2023
@ityuhui @revit13
Set go version to 1.18 (fybrik#1667)
770c60a 
Signed-off-by: Hui Yu <ityuhui@gmail.com>
revit13 added a commit that referenced this pull request Jan 15, 2023
@revit13
Set go version to 1.18 (#1667) (#1887)
5bc1fa8 
Signed-off-by: Hui Yu <ityuhui@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roytman roytman roytman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request to upgrade the version of go
3 participants
@ityuhui @roytman @revit13
0