8000 ⚠️ Code refactoring: apis cleanup by shlomitk1 · Pull Request #1653 · fybrik/fybrik · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

⚠️ Code refactoring: apis cleanup #1653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2022
Merged

⚠️ Code refactoring: apis cleanup #1653

merged 1 commit into from
Aug 1, 2022

Conversation

shlomitk1
Copy link
Contributor

Signed-off-by: Shlomit Koyfman shlomitk@il.ibm.com
This PR replaces definitions used in manager/apis that are not a part of CRDs. Examples:

  • Error messages
  • Connection types/formats used in tests/mockups
  • Names of labels

@shlomitk1
refactoring
f4566cd 
Signed-off-by: Shlomit Koyfman <shlomitk@il.ibm.com>
@shlomitk1 shlomitk1 requested a review from roytman July 31, 2022 8000 12:23
@simanadler
Copy link
Member

I'm struggling a bit to understand (1) what problem this is solving, (2) why put all the labels in utils, rather than with their related CRDs? Utils were meant for things used by multiple components.

@roytman
Copy link
Collaborator
roytman commented Jul 31, 2022 •
edited
Loading

I'm struggling a bit to understand (1) what problem this is solving, (2) why put all the labels in utils, rather than with their related CRDs? Utils were meant for things used by multiple components.

When we create a new CRD version, we copy the old one and add required changes. When all constants and helmValues are there, we will need or to remove them from old version or have double values.

Actually, the constants are not used by CRDs, they are used by controllers

@shlomitk1
Copy link
Contributor Author

FybrikAppUUID was defined in utils, other labels in manager/apis - not very consistent.

@roytman roytman merged commit 135c13a into fybrik:master Aug 1, 2022
@roytman roytman changed the title Code refactoring: apis cleanup ⚠️ Code refactoring: apis cleanup Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roytman roytman roytman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shlomitk1 @simanadler @roytman
0