8000 ⚠️ add v1beta1 support by roytman · Pull Request #1651 · fybrik/fybrik · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

⚠️ add v1beta1 support #1651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Aug 2, 2022
Merged

⚠️ add v1beta1 support #1651

merged 14 commits into from
Aug 2, 2022

Conversation

roytman
Copy link
Collaborator
@roytman roytman commented Jul 29, 2022 •
edited
Loading

Background of the PR.
We have published the v1.0.0 but did not update the CRDs apiVersions. According to Kubernetes backward compatibility starts from beta versions. Therefore, we have to promote our CRD versions to v1beta1

Signed-off-by: Alexey Roytman roytman@il.ibm.com

Co-authored-by: Alexey Roytman roytman@il.ibm.com
Co-authored-by: Raviv Schaffer raviv.schaffer@ibm.com

@roytman roytman force-pushed the v1beta1 branch 4 times, most recently from 2f2dd26 to b4b81ee Compare July 30, 2022 05:25
shlomitk1
shlomitk1 reviewed Jul 30, 2022
View reviewed changes
shlomitk1
shlomitk1 reviewed Jul 30, 2022
View reviewed changes
shlomitk1
shlomitk1 reviewed Jul 30, 2022
View reviewed changes
shlomitk1
shlomitk1 reviewed Jul 30, 2022
View reviewed changes
shlomitk1
shlomitk1 reviewed Jul 30, 2022
View reviewed changes
shlomitk1
shlomitk1 reviewed Jul 30, 2022
View reviewed changes
@simanadler
Copy link
Member

@roytman (1) Do we have a design doc describing how versioning is done, our overall approach to handling versions, etc? ex: will the version numbers of different CRDs be aligned? (2) why are we moving to beta instead of 1.0?

@roytman roytman changed the title add v1beta1 support add v1 support Jul 31, 2022
@roytman roytman force-pushed the v1beta1 branch 4 times, most recently from 84295ab to f41a06d Compare July 31, 2022 10:42
shlomitk1
shlomitk1 reviewed Jul 31, 2022
View reviewed changes
shlomitk1
shlomitk1 reviewed Jul 31, 2022
View reviewed changes
shlomitk1
shlomitk1 reviewed Jul 31, 2022
View reviewed changes
shlomitk1
shlomitk1 reviewed Jul 31, 2022
View reviewed changes
shlomitk1
shlomitk1 reviewed Jul 31, 2022
View reviewed changes
shlomitk1
shlomitk1 reviewed Jul 31, 2022
View reviewed changes
@roytman roytman marked this pull request as draft July 31, 2022 15:54
@roytman roytman force-pushed the v1beta1 branch 2 times, most recently from d632971 to e10811a Compare July 31, 2022 18:59
@revit13 revit13 mentioned this pull request Aug 1, 2022
Closed
@roytman
add v1beta1 support
bb67b8a 
Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
@roytman roytman force-pushed the v1beta1 branch 16 times, most recently from f70e486 to 76c75da Compare August 1, 2022 11:30
@roytman
return back to v1beta1
dbf4f7a 
Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
@roytman roytman marked this pull request as ready for review August 1, 2022 12:01
shlomitk1
shlomitk1 reviewed Aug 1, 2022
View reviewed changes
shlomitk1
shlomitk1 reviewed Aug 1, 2022
View reviewed changes
roytman added 2 commits August 2, 2022 04:58
@roytman
fix comments
079762a 
Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
@roytman
remove version name from webhooks names
638e810 
Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
@roytman roytman mentioned this pull request Aug 2, 2022
Closed
shlomitk1
shlomitk1 reviewed Aug 2, 2022
View reviewed changes
@roytman
fix katalog sample
907a60e 
Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
@roytman roytman merged commit 29e2dc1 into fybrik:master Aug 2, 2022
@roytman roytman deleted the v1beta1 branch October 11, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revit13 revit13 revit13 left review comments

@shlomitk1 shlomitk1 shlomitk1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roytman @simanadler @revit13 @shlomitk1
0