8000 fix print the ref of the last commit by roytman · Pull Request #1639 · fybrik/fybrik · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix print the ref of the last commit #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 27, 2022
Merged

fix print the ref of the last commit #1639

merged 2 commits into from
Jul 27, 2022

Conversation

roytman
Copy link
Collaborator
@roytman roytman commented Jul 24, 2022

Fixes print the reference of the last commit in manager, add it to OPA and Katalog connectors.

/closes #1638

Signed-off-by: Alexey Roytman roytman@il.ibm.com

revit13
revit13 previously approved these changes Jul 25, 2022
View reviewed changes
@revit13
Copy link
Collaborator
revit13 commented Jul 25, 2022 •
edited
Loading

btw there seems to be an alternative approach to avoid forgetting adding the flag: https://levelup.gitconnected.com/a-better-way-than-ldflags-to-add-a-build-version-to-your-go-binaries-2258ce419d2d

@roytman
Copy link
Collaborator Author
roytman commented Jul 25, 2022

btw there seems to be an alternative approach to avoid forgetting adding the flag: https://levelup.gitconnected.com/a-better-way-than-ldflags-to-add-a-build-version-to-your-go-binaries-2258ce419d2d

Cool, that was happened with the print in manager. Will update accordingly, thanks.

@roytman roytman marked this pull request as draft July 25, 2022 16:16
@roytman
Copy link
Collaborator Author
roytman commented Jul 25, 2022

After checking the suggested option, I don't think that it is better.

  1. We have to create a bash script files to generate the git info
  2. The solution generates version.txt (or some other predefined name files), there is an option that an old file will be used, at least in a local run.
  3. anyway, we have to update the build commands to include go generate before. If we don't run go generate and the version.txt doesn't exist, the build will fail, but if the file does exist, the build will be OK with an old version.
  4. if you work with IDE (goLand or VC) you have to run go generate each time before using the project. (I assume that version.txt, doesn't exist).

@revit13 what do you think ?

roytman added 2 commits July 25, 2022 22:06
@roytman
fix print the ref of the last commit
167eac5 
Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
@roytman
add version.mk
31a69bf 
Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
@revit13
Copy link
Collaborator
revit13 commented Jul 26, 2022

The fact that the old version.txt can be used seems dangerous (although if the code is always built from the Makefile the chances for that are low right?). it might be safer to have a scenario where the version is empty than incorrect.

@roytman roytman marked this pull request as ready for review July 26, 2022 11:02
@roytman roytman merged commit ca72891 into fybrik:master Jul 27, 2022
@roytman roytman deleted the gitref branch October 11, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revit13 revit13 revit13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the print of the ltest commit reference in manager, add to conenctors.
2 participants
@roytman @revit13
0