8000 Migrate to Ginkgo v2 by ityuhui · Pull Request #1612 · fybrik/fybrik · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
/ fybrik Public

Migrate to Ginkgo v2 #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2022
Merged

Migrate to Ginkgo v2 #1612

merged 2 commits into from
Jul 14, 2022

Conversation

ityuhui
Copy link
Contributor
@ityuhui ityuhui commented Jul 14, 2022

Fixes #1604

Signed-off-by: Hui Yu ityuhui@gmail.com

@ityuhui
Migrate to Ginkgo v2
e846e9e 
Signed-off-by: Hui Yu <ityuhui@gmail.com>
@ityuhui
Copy link
Contributor Author
ityuhui commented Jul 14, 2022

There are two failures. I'll try to resolve them.

Ginkgo detected an issue with your spec structure
By("Expecting application creation to succeed")
/home/runner/work/fybrik/fybrik/manager/controllers/app/fybrik_notebook_read_flow_test.go:116
  It looks like you are calling By outside of a running spec.  Make sure you
  call By inside a runnable node such as It or BeforeEach and not inside the
  body of a container such as Describe or Context.
Learn more at:http://onsi.github.io/ginkgo/#documenting-complex-specs-by

Ginkgo detected an issue with your spec structure
By("Starting deny write scenario")
/home/runner/work/fybrik/fybrik/manager/controllers/app/fybrik_notebook_write_flow_test.go:57
  It looks like you are calling By outside of a running spec.  Make sure you
  call By inside a runnable node such as It or BeforeEach and not inside the
  body of a container such as Describe or Context.
Learn more at:http://onsi.github.io/ginkgo/#documenting-complex-specs-by

@ityuhui
Replace By() since it cannot be called outside of a running spec in G…
61999a8 
…inkgo v2

Signed-off-by: Hui Yu <ityuhui@gmail.com>
@ityuhui
Copy link
Contributor Author
ityuhui commented Jul 14, 2022

All checks have passed now.

@roytman
Copy link
Collaborator
roytman commented Jul 14, 2022

@ityuhui , thanks for the PR.

roytman
roytman approved these changes Jul 14, 2022
View reviewed changes
Copy link
Collaborator
@roytman roytman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm merging it, later we probaly should check how to replace fmt.Printfs by By or something similar.

@roytman roytman merged commit 6d48312 into fybrik:master Jul 14, 2022
@ityuhui
Copy link
Contributor Author
ityuhui commented Jul 14, 2022

I'm merging it, later we probaly should check how to replace fmt.Printfs by By or something similar.

Yes. the better solution is updating the test specs in files fybrik_notebook_read_flow_test.go and fybrik_notebook_write_flow_test.go to use the latest code pattern of Ginkgo, just like some files already do, e.g.

fybrik/manager/controllers/app/fybrikapplication_controller_test.go

Line 111 in 6d48312

By("Expecting applications to be created")

But that will introduces big changes to the two files. Considering this PR focuses on Ginkgo v2 migration, we can merge it now and update them in the future.

@ityuhui ityuhui deleted the yh-migrate-ginkgo-v2-0714 branch July 14, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roytman roytman roytman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Ginkgo to v2
2 participants
@ityuhui @roytman
0