8000 support attr with multiple instance types by zivnevo · Pull Request #1586 · fybrik/fybrik · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

support attr with multiple instance types #1586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2022
Merged

support attr with multiple instance types #1586

merged 2 commits into from
Jul 3, 2022

Conversation

zivnevo
Copy link
Collaborator
@zivnevo zivnevo commented Jun 30, 2022

Signed-off-by: Ziv Nevo nevo@il.ibm.com
Fixes #1573

The solution is sum of sums. (the below pseudo-code doesn't show handling inter-region goals)

  • For each goal attribute:
    • For each instance-type
      • Create an array where the i-th entry is the attribute value for the relevant instance in position i in the data-path (e.g., the cost of the cluster in position i)
    • Create an array where the j-th entry is the sum of the vector for instance-type j (indexes are arbitrary)
    • Create a variable to hold the sum of the above sums array
  • Create a variable to hold the weighted sum of all goals

@zivnevo
support attr with multiple instance types
bb0f72c 
Signed-off-by: Ziv Nevo <nevo@il.ibm.com>
@zivnevo zivnevo requested a review from shlomitk1 June 30, 2022 09:06
@shlomitk1 shlomitk1 enabled auto-merge (squash) July 3, 2022 08:07
@shlomitk1 shlomitk1 merged commit ea98105 into fybrik:master Jul 3, 2022
@zivnevo zivnevo deleted the issue_1573_multple_instance_types branch July 4, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlomitk1 shlomitk1 shlomitk1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimizer: support multiple instance types for an attribute
2 participants
@zivnevo @shlomitk1
0