8000 Remove VAULT_ADDR and VAULT_API_ADDR from vault values.yaml file. by revit13 · Pull Request #1545 · fybrik/fybrik · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove VAULT_ADDR and VAULT_API_ADDR from vault values.yaml file. #1545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 23, 2022
Merged

Remove VAULT_ADDR and VAULT_API_ADDR from vault values.yaml file. #1545

merged 4 commits into from
Jun 23, 2022

Conversation

revit13
Copy link
Collaborator
@revit13 revit13 commented Jun 14, 2022

VAULT_ADDR and VAULT_API_ADDR are already defined in https://github.com/hashicorp/vault-helm/blob/v0.19.0/templates/server-statefulset.yaml and thus can be removed from the values.yaml file used in fybrik deployment.
This PR fixes the following warnings reported by @shlomitk1

W0607 08:48:45.034889 3755936 warnings.go:70] spec.template.spec.containers[0].env[13].name: duplicate name "VAULT_ADDR"
W0607 08:48:45.034920 3755936 warnings.go:70] spec.template.spec.containers[0].env[14].name: duplicate name "VAULT_API_ADDR"

@revit13
Remove VAULT_ADDR and VAULT_API_ADDR from vault values.yaml file.
0a42011 
Signed-off-by: Revital Sur <eres@il.ibm.com>
@revit13 revit13 marked this pull request as draft June 14, 2022 11:44
@revit13 revit13 marked this pull request as ready for review June 15, 2022 05:29
@revit13 revit13 merged commit b4eaebb into fybrik:master Jun 23, 2022
@revit13 revit13 deleted the vault131 branch June 23, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlomitk1 shlomitk1 shlomitk1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@revit13 @shlomitk1
0