Fix regressions #339
Merged
Fix regressions #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes 'uno test' fail when tests fail again and fixes the regression introduced by 1bf82b6 in fuse-open#322.
After we corrected the return type of Random.NextDouble() in fuse-open#337, one test started failing (silently due to the other regression). Assertion failed in 'Pow', at /home/travis/build/mortend/uno/lib/UnoCore/Tests/Math.Test.uno:552 Expected: 579968040960.0000000 But got : 579967451136.0000000 Using NextFloat() instead fixes the test, because NextDouble() used to return float before fuse-open#337.
mortend
added a commit
to mortend/uno
that referenced
this pull request
Jun 3, 2020
The warnings were accidentally introduced in fuse-open#339.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two regressions introduced in #322 and #337.