Improve Android AAR support #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When passing -DLIBRARY we'll build an Android library (AAR-file). This fixes build scripts to better handle libraries, and not to confuse them with apps.
Drop APK prefix because we're also using this to build AARs.
This logic should also handle AARs and app bundles, in addition to APKs.
|
It's nice to get this in before making a new canary release. Dependents are waiting for a clean NPM way to install this, and it's tested locally... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes build-scripts aware of AAR (Android library) that are produced instead of APK when passing
-DLIBRARY, and other fixes related to this.