Add more GHCs to CI config, fix hlint warnings and haddock links #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhrcek
commented
Apr 11, 2025
| @@ -10,22 +10,23 @@ | |||
| -- | |||
| -- * Basic | |||
| -- | |||
| -- * 'Data.Extensible.Class': basic membership operations. | |||
There was a problem hiding this comment.
Explanation of these changes:
These links are currently not working as you might have intended. Try clicking any of them here https://hackage.haskell.org/package/extensible-0.9.2/docs/Data-Extensible.html and you'll see it takes you back to the same page.
The proper way to link to modules is to surround their names in double quotes as explained in haddock documentation https://haskell-haddock.readthedocs.io/latest/markup.html#linking-to-modules
jhrcek
commented
8000
Apr 11, 2025
| @@ -96,7 +103,6 @@ library | |||
| , StateVar | |||
| , tagged | |||
| , template-haskell | |||
| , text | |||
There was a problem hiding this comment.
Removing unused dependency.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I like this package. I'm interested in using it in my project.
I'm just opening this "probing" PR to check whether you're actively maintaining this project and to see if you're open to accepting fixes (should I need some in the future, not that I do now 😄 )