8000 core web vitals fields by kylekizirian · Pull Request #118 · fullstorydev/hauser · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

core web vitals fields #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 5, 2022
Merged

core web vitals fields #118

merged 3 commits into from
Oct 5, 2022

Conversation

kylekizirian
Copy link
Contributor
@kylekizirian kylekizirian commented Oct 4, 2022 •
edited
Loading
  • Adds the new Core Web Vitals fields EventFirstInputDelay int64 , EventCumulativeLayoutShift float64, and LoadLargestPaintTime int64 to BaseExportFields.
  • Updates TestSchema_ReconcileWithExisting test cases with new fields.
  • Updates NewMockDataExportClient to use SortStable for deterministic sorting when two events have the same EventStart
  • Updates testdata files with go test -update

camphillips22
camphillips22 approved these changes Oct 5, 2022
View reviewed changes
Copy link
Collaborator
@camphillips22 camphillips22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@camphillips22
Copy link
Collaborator

Not sure why the checks aren't being reported by CircleCI. I'm going to bypass the branch protections to merge since the tests did in fact pass.

@camphillips22 camphillips22 merged commit ede5ec3 into fullstorydev:master Oct 5, 2022
@kylekizirian kylekizirian deleted the kyle/cwv-fields branch October 5, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camphillips22 camphillips22 camphillips22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylekizirian @camphillips22
0