8000 feat: fetch api token from env variable by miguelvr · Pull Request #115 · fullstorydev/hauser · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: fetch api token from env variable #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2022

Conversation

miguelvr
Copy link
Contributor
@miguelvr miguelvr commented May 5, 2022

avoid having to hardcode the api token in the config file by overriding it with the FULLSTORY_API_TOKEN environment variable

8000
@camphillips22
Copy link
Collaborator

Thank you for the PR, @miguelvr! Would you mind updating the README to document this feature?

@miguelvr
Copy link
Contributor Author

Thank you for the PR, @miguelvr! Would you mind updating the README to document this feature?

@camphillips22 will do

@miguelvr
Copy link
Contributor Author

@camphillips22 done! let me know if it should be referenced elsewhere

Copy link
Collaborator
@camphillips22 camphillips22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the improvement!

@camphillips22 camphillips22 merged commit 59cd887 into fullstorydev:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0