merge #18
Merged
merge #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A fix has been submitted to have this fixed on upstream, which is getting cherry-picked as a patch in this change. Additionally this change clean up all the overrides related to the upstream change, as well as nearby code that seems to be obsolete. Resolves brave/brave-browser#45455 Chromium changes: https://chromium.googlesource.com/chromium/src/+/a0bc8aeba09c0ec094a1d14a2032709610defd38 commit a0bc8aeba09c0ec094a1d14a2032709610defd38 Author: Claudio DeSouza <cdesouza@chromium.org> Date: Tue Apr 15 13:35:18 2025 -0700 [android] Support `NativeTheme::GetInstanceForNativeUi` This change allows `NativeTheme::GetInstanceForNativeUi` to return the current instance for the native theme as well, on Android, as this seems to be a historical leftover. Bug: 385988433 Change-Id: I077348afb8a239c67fa2b4157a886a0a710a61a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6454402 Reviewed-by: Elly FJ <ellyjones@chromium.org> Commit-Queue: Claudio DeSouza <cdesouza@chromium.org> Cr-Commit-Position: refs/heads/main@{#1447347}
…28718) The simpler fix here is to avoid any buffer operation. Resolves brave/brave-browser#45513
* Strip BidiControl from download file name * Fix downloads not working for data URIs * Remove data-uri check. Just don't display any host if there is none (following Safari and Chrome)
* Remove default = false for private browsing. Update all uses to explicitly specify private browsing.
Upgrade from Chromium 136.0.7103.25 to Chromium 136.0.7103.35
…uplifted) (#28713) * Add new arg to copy "CI/*" labels from PR Fixes brave/brave-browser#45503 * presubmit fixes
Remove conversation api feature flag and unused engine classes
This change introduces `brockit_test.py` which will be used to host most of the `brockit` tests. Resolves brave/brave-browser#45536
This PR removes the `UNSAFE_TODO` occurrance in this test, and also simplifies the file creation that was relying on it. Resolves brave/brave-browser#45512
Disable kOutlineSilhouetteIcon so we don't display a silhouette icon instead of the default Brave avatar icon. Chromium change: https://source.chromium.org/chromium/chromium/src/+/83106df76363b6a0f301dd60745e711751cf88cd commit 83106df76363b6a0f301dd60745e711751cf88cd Author: David Roger <droger@chromium.org> Date: Thu Mar 13 14:09:39 2025 -0700 Reland "[Uno-D] Enable Phase 0 fast-follow flags by default" This is a reland of commit cefe36665901c8a494126cbf669708aaefd3d955 Original change's description: > [Uno-D] Enable Phase 0 fast-follow flags by default > > Enables by default: > * kOutlineSilhouetteIcon > * kImprovedSigninUIOnDesktop > * kImprovedSettingsUIOnDesktop > * kAutofillRemovePaymentsButterDropdown > > Bug: 356606258 > Change-Id: I6451cd1120eadad0f9e003591e04a6e9a20efcf1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6335520 > Commit-Queue: David Roger <droger@chromium.org> > Reviewed-by: Liza Bipin <mlbipin@google.com> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Olivia Saul <jsaul@google.com> > Cr-Commit-Position: refs/heads/main@{#1432071} Bug: 356606258
…utline-silhouette-icon Disable kOutlineSilhouetteIcon feature flag
#28726) * Fixed some NullAway Java warnings and suppressed some others * Suppressed warning around ContextUtils.getAppSharedPreferences() because we cannot depend on //chrome from //base to use ChromeSharedPreferences Fixes brave/brave-browser#45541
…28728) * [cr137] [Android] Wait for native initialization when creating bottom strip Chromium change: https://chromium.googlesource.com/chromium/src/+/ea006a988d2a36db0eb25801e1c02e9c6e9f5b86 [Tab Group UI] Wait for native initialization when creating bottom strip Wait for native initialization to complete before initializing the bottom tab strip. Otherwise it will try to initialize pre-native and crash. This appears to have regressed in M134/M135 likely due to some lifecycle change for the BottomControlsCoordinator. Fixed: 407305088 * Suppressed warning around ContextUtils.getAppSharedPreferences() --------- Co-authored-by: Artem Samoilenko <artem@brave.com>
) * Update perf profile brave-typical-win using v1.80.28 * Update perf profile chrome-typical-win using v1.80.28 * Update perf profile brave-typical-mac using v1.80.30 * Update perf profile brave-typical-android using v1.80.25 * Update perf profile chrome-typical-mac using v1.80.30 * Update perf profile chrome-typical-android using v1.80.25
Add metrics for permission lifetimes
…8945) This method was renamed during the original dev cycle which would cause calls that used default arguments to be recursive for example during Brave Translate onboarding
…rts (#28929) bump web3.js to fix transitive security alerts
Implements a strategy to bring back picture in picture support for YouTube videos. Picture in picture implementation is behind feature flag `kBravePictureInPictureForYouTubeVideos` enabled by default. Test coverage has been extensively discussed and introduced to make sure: - We don't have race conditions when injecting the JS script - We don't inject the script multiple times on same page navigation - We don't create side effects in case of unexpected changes, and/or serialzed flags don't match - We inject/modify the serialized flags in case of partial match --------- Co-authored-by: bridiver <34129+bridiver@users.noreply.github.com>
…R profile (#28960) * Fixes a crash when Brave News service cannot be created in case of private profile
[Webcompat reporter dialog] Screenshot preview link unavailable (brave/brave-browser#45884) Signed-off-by: Vadym Struts <vstruts@brave.com>
This was an upstream patch that was now merged into M136 Chormium change: https://chromium.googlesource.com/chromium/src/+/75758fbd959f40edca5e1d80f906682aaf2ba31f commit 75758fbd959f40edca5e1d80f906682aaf2ba31f Author Martin Kong <martinkong@google.com> Date: Fri May 02 23:02:14 2025 [M136] Fix a crash that happens when the user removes an enabled flag Original change's description: > Fix a crash that happens when the user removes an enabled flag > > When the user enables a flag and then removes the flag from codebase, > Chrome Android will crash on startup because it assumes that all > previously enabled flags exist. This CL fixes this crash by just > moving on if a previously enabled flag does not exist anymore. > > Bug: 409983752 > Change-Id: I5d92662c0111d31b2fb6a843d2fa02ba0e310dd0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6455543 > Commit-Queue: Martin Kong <martinkong@google.com> > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> > Reviewed-by: Elly FJ <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1446676} Bug: 415316897,409983752
Update from Chromium 136.0.7103.60 to Chromium 136.0.7103.93.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves