8000 Resolve regex library warnings by emmanuel-ferdman · Pull Request #8890 · esphome/esphome · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Resolve regex library warnings #8890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 26, 2025
Merged

Resolve regex library warnings #8890

merged 2 commits into from
May 26, 2025
+3 −1

Conversation

emmanuel-ferdman
Copy link
Contributor

What does this implement/fix?

This small PR resolves the regex library warnings which you can find in the CI logs:

/home/runner/work/esphome/esphome/esphome/cpp_generator.py:419: DeprecationWarning: 'count' is passed as positional argument

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests
  • Other

Related issue or feature (if applicable):

  • fixes

Pull request in esphome-docs with documentation (if applicable):

  • esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

8000
@emmanuel-ferdman
Resolve regex library warnings
2e1e001 
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
@emmanuel-ferdman emmanuel-ferdman requested a review from a team as a code owner May 23, 2025 13:18
@codecov-commenter
Copy link
codecov-commenter commented May 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.65%. Comparing base (4d8b5ed) to head (22486d8).
Report is 2700 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #8890      +/-   ##
==========================================
+ Coverage   53.70%   56.65%   +2.94%     
==========================================
  Files          50       50              
  Lines        9408     9939     +531     
  Branches     1654     1341     -313     
==========================================
+ Hits         5053     5631     +578     
+ Misses       4056     3963      -93     
- Partials      299      345      +46

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@emmanuel-ferdman
Resolve regex library warnings
22486d8 
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
@jesserockz jesserockz merged commit 5921a9c into esphome:dev May 26, 2025
25 checks passed
This was referenced Jun 11, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesserockz jesserockz jesserockz approved these changes

Assignees
No one assigned
Labels
core small-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emmanuel-ferdman @codecov-commenter @jesserockz
0