8000 [bme68x_bsec2_i2c] Remove arduino dependency by luar123 · Pull Request #7815 · esphome/esphome · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[bme68x_bsec2_i2c] Remove arduino dependency #7815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 25, 2025
Merged

[bme68x_bsec2_i2c] Remove arduino dependency #7815

merged 2 commits into from
May 25, 2025

Conversation

luar123
Copy link
Contributor
@luar123 luar123 commented Nov 24, 2024 •
edited
Loading

What does this implement/fix?

Remove Arduino dependency of bme68x_bsec2_i2c component and allow to build with esp-idf.
I will keep this in draft state until PRs boschsensortec/Bosch-BME68x-Library#8 and boschsensortec/Bosch-BSEC2-Library#50 are merged. For now, my forks are used.

BSEC2 library update to v1.10.2610 also allows to build for currently unsupported esp32 variants like C6, H2, P4, etc. as well as some arm variants like RP2040.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests
  • Other

Related issue or feature (if applicable):

Pull request in esphome-docs with documentation (if applicable):

  • esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link
codecov-commenter commented Nov 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.65%. Comparing base (4d8b5ed) to head (2bccb00).
Report is 2702 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #7815      +/-   ##
==========================================
+ Coverage   53.70%   56.65%   +2.95%     
==========================================
  Files          50       50              
  Lines        9408     9940     +532     
  Branches     1654     1341     -313     
==========================================
+ Hits         5053     5632     +579     
+ Misses       4056     3963      -93     
- Partials      299      345      +46

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jesserockz
Copy link
Member

Awesome, lets hope Bosch notice and merge your PRs.

@guillempages guillempages mentioned this pull request Feb 6, 2025
Open
@lkm
Copy link
lkm commented May 22, 2025 •
edited
Loading

They finally did, both of them. Does this need anything else to work? I guess just updating the versions and pointed back to official repos. Bosch-BSEC2-Library v1.10.2610 and Bosch-BME68x-Library v1.3.40408

@lkm
Copy link
lkm commented May 22, 2025

The other PR to fix libpath was merged and tagged too (boschsensortec/Bosch-BSEC2-Library#55), fixed version ref above.

@luar123 luar123 marked this pull request as ready for review May 24, 2025 21:13
@luar123 luar123 requested a review from kbx81 as a code owner May 24, 2025 21:13
@probot-esphome
Copy link

Hey there @kbx81, @neffs, mind taking a look at this pull request as it has been labeled with an integration (bme68x_bsec2_i2c) you are listed as a code owner for? Thanks!
Hey there @kbx81, @neffs, mind taking a look at this pull request as it has been labeled with an integration (bme68x_bsec2) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@luar123
Copy link
Contributor Author
luar123 commented May 24, 2025

Updated library paths and added tests for esp-idf and rp2040.

@kbx81
Copy link
Member
kbx81 commented May 24, 2025

I love it! Will test here this weekend...

@kbx81 kbx81 changed the title Remove arduino dependency of bme68x_bsec2_i2c [bme68x_bsec2_i2c] Remove arduino dependency May 24, 2025
@kbx81
Copy link
Member
kbx81 commented May 25, 2025

Working great on three of my thermostats! 🎉

@kbx81 kbx81 merged commit 4b5c3e7 into esphome:dev May 25, 2025
28 checks passed
@luar123
Copy link
Contributor Author

Thanks!
The library update also alows to build for all other esp32 variants: C6/H2/P4 etc

@edwardtfn edwardtfn mentioned this pull request May 25, 2025
Open
sa-crespo pushed a commit to sa-crespo/esphome that referenced this pull request May 26, 2025
@luar123 @sa-crespo
[bme68x_bsec2_i2c] Remove arduino dependency (esphome#7815)
f00ac01
@jesserockz jesserockz mentioned this pull request Jun 11, 2025
Merged
@jesserockz jesserockz mentioned this pull request Jun 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbx81 kbx81 kbx81 approved these changes

Assignees

@kbx81 kbx81

Labels
has-tests integration: bme68x_bsec2_i2c integration: bme68x_bsec2 notable-change small-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BME680 BSEC support framework esp-idf
5 participants
@luar123 @codecov-commenter @jesserockz @lkm @kbx81
0