8000 Run task for VS Code by gitolicious · Pull Request #1361 · esphome/esphome · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Run task for VS Code #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 13, 2020
Merged

Run task for VS Code #1361

merged 3 commits into from
Dec 13, 2020

Conversation

gitolicious
Copy link
Contributor

Description:

In #914 (comment) it was stated by @Anonym-tsk to use Tasks: Run Task in VS Code dev container though the tasks.json is currently excluded from the repo. If you have a more comprehensive list of useful tasks, feel free to amend.

Related issue (if applicable): fixes n/a

Pull request in esphome-docs with documentation (if applicable): n/a

Checklist:

  • The code change is tested and works locally.
  • [n/a] Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@jesserockz
Copy link
Member

Does this work with a virtualenv though to use the local development version of esphome?

@gitolicious
Copy link
Contributor Author
gitolicious commented Nov 8, 2020 •
edited
Loading

I never really used virtualenv? Compared to dev containers that's two different solutions for the same problem that don't occur together. Still we will need to provide the appropriate task config for the corresponding environment.

How would the command look like in a virtualenv?

@glmnet glmnet merged commit 7afe202 into esphome:dev Dec 13, 2020
@glmnet
Copy link
Member
glmnet commented Dec 13, 2020

Thanks,

What about a doc section on the contributing guide, or somewhere else, on how to use dev containers and all the features it has already?

@gitolicious
Copy link
Contributor Author

I'm sure that would be helpful. I just started using them myself for ESPHome, so would need some help by others who worked with them more comprehensively.

This was referenced Jan 7, 2021
Merged
Merged
Merged
Merged
This was referenced Feb 3, 2021
Merged
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
small-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gitolicious @jesserockz @glmnet
0