Add Fan and Swing Support to fujitsu-general Component #1287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glmnet
approved these changes
Sep 22, 2020
sashao
pushed a commit
to sashao/esphome
that referenced
this pull request
Oct 23, 2020
* Added fan and swing support to fujitsu-general * fixed formatting
This was referenced Jan 7, 2021
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds fan speed and swing support to the fujitsu_general component. It also adds support for "dry" and "fan only" modes. It doesn't look like documentation needs to be changed for these code changes.
Tested on my Fujitsu ASU12RLS.
Related issue (if applicable): NA
Pull request in esphome-docs with documentation (if applicable): NA
Checklist:
tests/folder).If user exposed functionality or configuration variables are added/changed:
Documentation added/updated in esphome-docs.