Updated Mcp3008 to support reference_voltage and voltage_sampler::VoltageSampler #874
Conversation
There was a problem hiding this comment.
Please check the example indentation.
Also please don't inflate the example so much. Its best left with the minimum requirements to use the component. eg. don't need the "fridge" config as well. Best if you just add the reference_voltage line into the existing example.
Sounds good. ill do it over the weekend. |
f2b085c to
fe2fec6
Compare
Add pictures and parent documentation clarified a few things
|
Made a few changes and I hope this completed the doc. It was lacking to say the least! Sorry about that |
|
@jesserockz I changed the png image to jpg and now the changelog doesnt match throwing a lint error. I could put the file back and have both or do I edit the changelog to point to the right file? |
|
I think the PNG file is corrupt but because it's still present in the branch it is causing errors. I am only on my phone so can't check properly. |
…tageSampler (#874) Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Description:
Updated the sensor to return the voltage read to match how the ADC component works.
Related issue (if applicable): fixes
Pull request in esphome with YAML changes (if applicable): esphome/esphome#1387
Checklist:
nextis for changes and new documentation that will go public with the next ESPHome release. Fixes, changes and adjustments for the current release should be created againstcurrent./index.rstwhen creating new documents for new components or cookbook.This is just an update to the current doc