Add separate current/target Tuya Climate multipliers #828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
3 tasks
jesserockz
requested changes
Nov 9, 2020
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
|
Moved new config options under the |
jesserockz
reviewed
Nov 10, 2020
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
jesserockz
approved these changes
Nov 11, 2020
This was referenced Jan 7, 2021
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Some Tuya thermostats have different multipliers for current and target temperatures.
So the current approach (having a single
temperature_multiplier) cannot handle both cases.This is breaking change, it introduces separate multipliers for both values
**Related issue (if applicable):
**Pull request in esphome with YAML changes (if applicable):
esphome/esphome#1345
Checklist:
nextis for changes and new documentation that will go public with the next ESPHome release. Fixes, changes and adjustments for the current release should be created againstcurrent./index.rstwhen creating new documents for new components or cookbook.