10000 add rc522 docs by glmnet · Pull Request #810 · esphome/esphome-docs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add rc522 docs #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2020
Merged

add rc522 docs #810

merged 1 commit into from
Oct 26, 2020

Conversation

glmnet
Copy link
Member
@glmnet glmnet commented Oct 13, 2020

Description:

Add RC522 docs

Pull request in esphome with YAML changes (if applicable): esphome/esphome#1298

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next ESPHome release. Fixes, changes and adjustments for the current release should be created against current.
  • Link added in /index.rst when creating new documents for new components or cookbook.

Copy link
Member
@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesserockz jesserockz merged commit d84787b into next Oct 26, 2020
@jesserockz jesserockz deleted the add-rc-522-spi branch October 26, 2020 23:42

.. code-block:: yaml

rc522:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still correct, or should it be rc522_spi after the rename of the component?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, should be rc522_spi, actually should be something generic like rc522_... (once i2c support docs are done)

This was referenced Feb 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0