Fix old screenshots #716
Merged
Fix old screenshots #716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it a good idea current being default branch? I see lots of people confusing it usually, not that it just happened too me 👀 |
|
@glmnet Depends on what you want to optimize. If you want to make it easy to submit documentation fixes/improvements on the Vice versa for next branch and new integrations. Unfortunately GitHub just doesn't give us the tools to optimize both (at least last time I checked, but things might have changed since then). I believe this is also the setting home-assistant.io repo uses. |
OttoWinter
approved these changes
Jul 28, 2020
There was a problem hiding this comment.
Thanks! Yeah we should probably re-do some of the screenshots for the new release (especially in https://github.com/esphome/hassio)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Just replaced two screenshots. Also removed one image as it was a duplicate
Related issue (if applicable): fixes
Pull request in esphome with YAML changes (if applicable): esphome/esphome#
Checklist:
nextis for changes and new documentation that will go public with the next ESPHome release. Fixes, changes and adjustments for the current release should be created againstcurrent./index.rstwhen creating new documents for new components or cookbook.