feat: Add extendable config types #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request adds new extendable interfaces for ESLint's configuration, allowing plugins to extend settings and rules.
- Added new interfaces (SettingsConfig, RulesConfig, and extended LinterOptionsConfig) in the core types.
- Updated tests to verify the new type definitions.
- Modified the eslint.config.js file to ignore test files.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/tests/types/types.test.ts | Added tests for the new config types and sample rule configurations; note a potential typo. |
| packages/core/src/types.ts | Updated type definitions to include extended interfaces for settings and rules configurations. |
| eslint.config.js | Added an ignore pattern for test files to improve configuration behavior. |
Comments suppressed due to low confidence (1)
packages/core/tests/types/types.test.ts:76
- The variable 'ruelConfig5' appears to be misspelled; consider renaming it to 'ruleConfig5' for clarity.
const ruelConfig5: RuleConfig<[{ available: "widely" | "newly" }]> = [
fasttime
reviewed
May 23, 2025
fasttime
reviewed
May 23, 2025
Co-authored-by: Francesco Trotta <github@fasttime.org>
fasttime
approved these changes
May 24, 2025
|
@mdjermanovic can you take a look at this? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Adds interfaces for
settingsandrulescan be extended by plugins.What changes did you make? (Give an overview)
SettingsConfiginterfaceRulesConfiginterfaceLinterOptionsConfiginterface (for completeness)Related Issues
fixes #208
Is there anything you'd like reviewers to focus on?
Just a note that once this is released, we'll need to update the
Configtype in theeslintpackage.