8000 migrate from external mock package to stdlib unittest.mock by eli-schwartz · Pull Request #1673 · errbotio/errbot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

migrate from external mock package to stdlib unittest.mock #1673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 31, 2023
Merged

migrate from external mock package to stdlib unittest.mock #1673

merged 1 commit into from
Dec 31, 2023

Conversation

eli-schwartz
Copy link
Contributor

It was moved to the stdlib in python 3.3, and the PyPI version is a backport for python versions less than 3.3.

@nzlosh
Copy link
Contributor
nzlosh commented Dec 4, 2023

The CHANGELOG should also be updated.

@eli-schwartz
migrate from external mock package to stdlib unittest.mock
22ad3c5 
It was moved to the stdlib in python 3.3, and the PyPI version is a
backport for python versions less than 3.3.
@eli-schwartz
Copy link
Contributor Author

Done.

@nzlosh
Copy link
Contributor
nzlosh commented Dec 4, 2023

@sijis LGTM

@sijis sijis merged commit dc44e7f into errbotio:master Dec 31, 2023
@sijis
Copy link
Contributor
sijis commented Dec 31, 2023

@eli-schwartz thank you!

@eli-schwartz eli-schwartz deleted the stdlib-mock branch December 31, 2023 21:11
sijis pushed a commit to sijis/errbot that referenced this pull request Jan 1, 2024
@eli-schwartz @sijis
migrate from external mock package to stdlib unittest.mock (errbotio#…
a24b31d 
…1673)

It was moved to the stdlib in python 3.3, and the PyPI version is a
backport for python versions less than 3.3.
kayman-mk pushed a commit to Hapag-Lloyd/errbot that referenced this pull request Apr 21, 2025
@eli-schwartz @kayman-mk
migrate from external mock package to stdlib unittest.mock (errbotio#…
058f3e8 
…1673)

It was moved to the stdlib in python 3.3, and the PyPI version is a
backport for python versions less than 3.3.
kayman-mk pushed a commit to Hapag-Lloyd/errbot that referenced this pull request Apr 21, 2025
@eli-schwartz @kayman-mk
migrate from external mock package to stdlib unittest.mock (errbotio#…
bf0f981 
…1673)

It was moved to the stdlib in python 3.3, and the PyPI version is a
backport for python versions less than 3.3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijis sijis sijis approved these changes

@nzlosh nzlosh nzlosh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eli-schwartz @nzlosh @sijis
0