8000 Rework Dockerfile and prepare for SlackV3 Backend by duhow · Pull Request #1604 · errbotio/errbot · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Rework Dockerfile and prepare for SlackV3 Backend #1604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

duhow
Copy link
Contributor
@duhow duhow commented Oct 1, 2022

This is a major rework of the Dockerfile , mainly requires using buildx to mount the wheel packages instead of copying them to the image.

⚠️ NOTE: As of errbotio/err-backend-slackv3@908d822 , slackv3 dependencies cannot be installed - feel free to contribute back with this.

  • Easy way to define extra dependencies for Errbot (irc, xmpp, telegram, others)
  • Define BASE_IMAGE
  • Use git clone depth to reduce git size
  • Stop errbot with SIGINT (actual shutdown of application)
  • Compact layers by using less RUN statements

8000
@sijis
Copy link
Contributor
sijis commented Oct 1, 2022

I think once the slackv3 pip package is created, it should just be an update to the pio install command.

@duhow
Copy link
Contributor Author
duhow commented Oct 5, 2022

By installing backend-slackv3 package from pip I have the following error:

Traceback (most recent call last):
  File "/usr/local/bin/errbot", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.9/site-packages/errbot/cli.py", line 287, in main
    ep = entry_point_plugins(group="errbot.backend_plugins")
  File "/usr/local/lib/python3.9/site-packages/errbot/utils.py", line 208, in entry_point_plugins
    paths.append(entry_point.dist._path.parent)
AttributeError: 'EntryPoint' object has no attribute 'dist'

@duhow
Copy link
Contributor Author
duhow commented Oct 5, 2022

Argh. New release. https://pypi.org/project/importlib-metadata/5.0.0/

@sijis
Copy link
Contributor
sijis commented Oct 6, 2022

I have pr #1603 that should address that message. Give it a shot and see if it works.

@duhow
Copy link
Contributor Author
duhow commented Oct 6, 2022

That seems to work @sijis ! Please review.

@sijis
Copy link
Contributor
sijis commented Oct 24, 2022

Fixed via #1608 and #1603.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0