Add middleware to record YJIT code_region_size #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
- We are using the rack.after_reply hook for this to not impact response times - https://github.blog/2022-04-11-performance-at-github-deferring-stats-with-rack-after_reply/
- Just a simple implimentation now, so we can optimise --yjit-exec-mem-size on applications, but this should be simple to extend to record the other metrics exposed by runtime_stats if they are needed.
* We are using the rack.after_reply hook for this to not impact response times - https://github.blog/2022-04-11-performance-at-github-deferring-stats-with-rack-after_reply/ * Just a simple implimentation now, so we can optimise --yjit-exec-mem-size on applicat 8000 ions, but this should be simple to extend to record the other metrics exposed by runtime_stats if they are needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.