8000 Move acknowledgement from code comments to README by Bodacious · Pull Request #32 · errm/promenade · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Move acknowledgement from code comments to README #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Aug 23, 2022
Merged

Move acknowledgement from code comments to README #32

merged 15 commits into from
Aug 23, 2022

Conversation

Bodacious
Copy link
Collaborator
@Bodacious Bodacious commented Aug 12, 2022 •
edited
Loading

What

Move acknowledgements out of the comments and into the README

Why

This is a bit of a stink to have in the code. The code we use has deviated quite a bit from the original Collector class, and so I think the comment is less than useful.

How

  • Removed related comments.
  • Added an acknowledgment to the README.

@Bodacious Bodacious changed the base branch from master to gm/queue-time-tracking August 12, 2022 12:04
Base automatically changed from gm/queue-time-tracking to master August 23, 2022 08:33
@Bodacious Bodacious merged commit 2e30a07 into master Aug 23, 2022
@Bodacious Bodacious deleted the gm/acknowledgement branch August 23, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@errm errm errm approved these changes

@robertomiranda robertomiranda robertomiranda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bodacious @errm @robertomiranda
0