Handle .tool-versions' line break on Windows
#357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b0f166e to
5d50771
Compare
<
8000
/div>
5d50771 to
91c62ff
Compare
|
In the first commit (adds a specific line-ending test) this is failing + '27.3.4.1\r'
- '27.3.4.1' |
6932308 to
25df23a
Compare
|
@Hermanverschooten, I think this fixes your issue Give it a spin, and lemme know so I can cut a release: uses: erlef/setup-beam@fix/_tool-versions-split-for-winCheers. |
|
Works like a charm ❤️ |
|
Requesting review for visibility, but this is a simple fix with low impact, so I'm merging to release a version. |
|
This is released in v1.20.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This'll hopefully fix the bug reported in the linked issue.
Closes #355.