8000 Match only on what we know should match (versions start with numbers, after OTP-) by paulo-ferraz-oliveira · Pull Request #341 · erlef/setup-beam · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Match only on what we know should match (versions start with numbers, after OTP-) #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2025
Merged

Match only on what we know should match (versions start with numbers, after OTP-) #341

merged 2 commits into from
May 30, 2025

Conversation

paulo-ferraz-oliveira
Copy link
Collaborator
@paulo-ferraz-oliveira paulo-ferraz-oliveira commented May 30, 2025 •
edited
Loading

Description

Act on a weakness update suggested by CodeQL's scanning: https://github.com/erlef/setup-beam/security/code-scanning/23.

(at most 3 digits for major version)

github-advanced-security[bot]
github-advanced-security bot found potential problems May 30, 2025
View reviewed changes
@paulo-ferraz-oliveira paulo-ferraz-oliveira force-pushed the fix/for-performance branch 4 times, most recently from 07c679e to 40d93a2 Compare May 30, 2025 02:33
github-advanced-security[bot]
github-advanced-security bot found potential problems May 30, 2025
View reviewed changes
@paulo-ferraz-oliveira paulo-ferraz-oliveira force-pushed the fix/for-performance branch 2 times, most recently from 11f6bd1 to cb69641 Compare May 30, 2025 02:48
@paulo-ferraz-oliveira
Approach existing code to known elements
31bb288 
We were missing maint in isKnownVersion, for example
@paulo-ferraz-oliveira
Copy link
Collaborator Author

@starbelly, if you see this and agree with the content feel free to merge. Otherwise I'll act on comments later 😄 👋

@starbelly starbelly merged commit afe5922 into main May 30, 2025
73 checks passed
@starbelly starbelly deleted the fix/for-performance branch May 30, 2025 04:43
@paulo-ferraz-oliveira
Copy link
Collaborator Author

This was released in v1.20.0.

@paulo-ferraz-oliveira paulo-ferraz-oliveira mentioned this pull request Jun 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starbelly starbelly starbelly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulo-ferraz-oliveira @starbelly
0