Fix for rebar3 nightly/latest
#331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
| elixir-version: '1.16' | ||
| rebar3-version: '3' | ||
| rebar3-version: '3.25' |
There was a problem hiding this comment.
We pin it, so it doesn't catch us by surprise in the (near?) future.
| @@ -145,11 +142,11 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| combo: | |||
There was a problem hiding this comment.
We benefit from latest, consistently, and thus this should break much less in the future.
| @@ -128,11 +125,11 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| combo: | |||
There was a problem hiding this comment.
We benefit from latest, consistently, and thus this should break much less in the future.
These tests seem to present issues in rebar3 (taking forever to compile) or verl, so I'm avoiding nightly, for now
Not exactly sure what's wrong with this one, but I don't think (given all the other successes in the actions' tests) this is action-specific
|
I wrote this one to unlock #330 as it's failing since 3.25 came out, but due to our tests, not the proposed changes. Feel free to merge if you approve. |
|
This change was released in v1.19.0, also tagged |
|
👍 |
Comment on lines
-47
to
-49
| - otp-version: '26.1' | ||
| rebar3-version: 'nightly' | ||
| os: 'windows-2019' |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Compatibility with Erlang/OTP versions lower than 26 is not guaranteed, so we try to move the versions forward / adapt them, when warranted to prevent issues around e.g.
rebar3releases like the recent 3.25 one.