Add ability to specify OTP architecture #316
Conversation
|
This LGTM. Would like to see what @paulo-ferraz-oliveira . |
|
@starbelly do you think the failing check is some transient issue with builds.hex.pm? Would you be able to rerun it? |
That indeed was the issue. This LGTM and @wojtekmach seemed to think so as well. |
| - uses: erlef/setup-beam@v1 | ||
| with: | ||
| otp-version: '26' | ||
| otp-architecture: '32' |
There was a problem hiding this comment.
sorry I haven't responded sooner. Why is this 32 as opposed to x86/x86_64? I believe the latter would be more future proof as there is slowly arm64-windows support being added: https://github.com/erlang/otp/pull/8991/files.
That being said it is fine to wait for arm builds to show up and we could deprecate 32/64 in favor of x86/x86_64 (note: you're gonna be able to run x86_64/x86_64 on arm64 windows but not the other way around) but I don't see a downside in doing it right now.
There was a problem hiding this comment.
Hey @wojtekmach , no release has been cut, if we need to we can revert, but also sounds like it's a future proof issue.
|
This change was released in v1.19.0, also tagged |
Description
Closes #315 .
n.b. I have checked
npm testand it is returning an exit code of 0, but there is a massive amount of debug output so I could not see any success/fail messages from testing.