8000 Be explicit about which file (.bat / .cm) is executed in the Windows installation flow by lukebakken · Pull Request #198 · erlef/setup-beam · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Be explicit about which file (.bat / .cm) is executed in the Windows installation flow #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2023
Merged

Be explicit about which file (.bat / .cm) is executed in the Windows installation flow #198

merged 1 commit into from
May 3, 2023

Conversation

lukebakken
Copy link
Contributor

In my Windows 11 test environment, using Powershell Core 7.3.4, I get the following message while running similar code to what this github action uses:

Installed Elixir version follows
InvalidOperation: C:\Users\vagrant\setup-beam\src\test.ps1:4
Line |
   4 |  & "${DIR_FOR_BIN}/bin/elixir" "-v" | Write-Output
     |  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Cannot run a document in the middle of a pipeline: C:\elixir\bin\elixir.

Adding .bat fixes the issue. This is probably not the root cause of #189, however.

In my Windows 11 test environment, using Powershell Core 7.3.4, I get
the following message while running similar code to what this github
action uses:

```
Installed Elixir version follows
InvalidOperation: C:\Users\vagrant\setup-beam\src\test.ps1:4
Line |
   4 |  & "${DIR_FOR_BIN}/bin/elixir" "-v" | Write-Output
     |  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Cannot run a document in the middle of a pipeline: C:\elixir\bin\elixir.
```

Adding `.bat` fixes the issue. This is probably not the root cause of
#189, however.
@paulo-ferraz-oliveira
Copy link
Collaborator

Nice catch. If CI passes, I'm merging this. Thanks.

@paulo-ferraz-oliveira paulo-ferraz-oliveira changed the title Be explicit about which file to run Be explicit about which file (.bat / .cm) is executed in the Windows installation flow May 3, 2023
@paulo-ferraz-oliveira paulo-ferraz-oliveira self-requested a review May 3, 2023 09:49
@paulo-ferraz-oliveira paulo-ferraz-oliveira merged commit 9641cb9 into erlef:main May 3, 2023
@paulo-ferraz-oliveira
Copy link
Collaborator

Done. Many thanks.

@paulo-ferraz-oliveira
Copy link
Collaborator

Released in v1.16.0 / v1.16. Tag v1 moved up...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0