Add environment variables #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(win22 is just a guess, at this moment)
|
I'm going to break this into 2 commits, since one of them is basically code maintenance and pollutes the revision. |
| @@ -6,14 +6,16 @@ Set-Location $Env:RUNNER_TEMP | |||
|
|
|||
| $FILE_INPUT="gleam-${VSN}-windows-64bit.zip" | |||
| $FILE_OUTPUT="gleam.zip" | |||
| $DIR_FOR_BIN=".setup-beam/gleam/bin" | |||
| $DIR_FOR_BIN=".setup-beam/gleam" | |||
There was a problem hiding this comment.
The tweaking of bin, here, was basically for consistency with the other outputs (otherwise we'd have to attach the bin to Gleam's base folder).
|
70a59a5 basically adds a lot of |
starbelly
approved these changes
Feb 20, 2022
8000
|
Rebased on top of |
|
This is now Ok, after the rebase. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces some env. variables to the run, namely the ones identified in the
README.md:INSTALL_DIR_FOR_ELIXIR: base folder for Erlang/OTPINSTALL_DIR_FOR_GLEAM: base folder for ElixirINSTALL_DIR_FOR_OTP: base folder for GleamINSTALL_DIR_FOR_REBAR3: base folder forrebar3and hopefully it closes #89 (still waiting on a comment/test by @samaaron)