10000 Automate updating 3rd party licenses by paulo-ferraz-oliveira · Pull Request #82 · erlef/setup-beam · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Automate updating 3rd party licenses #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Automate updating 3rd party licenses #82

merged 2 commits into from
Jan 12, 2022

Conversation

paulo-ferraz-oliveira
Copy link
Collaborator

Does this seem like a good enough option?

Closes #76.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

I'm purposefully not updating the 3rd party licenses, to have this scheduled action happen on main, where it should work.

@starbelly
Copy link
Member
starbelly 8000 commented Jan 11, 2022

@paulo-ferraz-oliveira I was more thinking something that just runs a build, we should get notified if it fails. If it fails, then we know we need to update the licenses.

The thing that I guess makes me nervous about this is nodejs deps 😬 Maybe I'm overly concerned here?

@paulo-ferraz-oliveira
Copy link
Collaborator Author

Hm. I'm not worried, since the dependencies are kept by the action container itself. In any case, we can always try and see how it goes, right?

@starbelly
Copy link
Member

@paulo-ferraz-oliveira Fair enough. Just need to be sure to review commits before release :)

Can you rebase this so it passes?

@paulo-ferraz-oliveira
Copy link
Collaborator Author

Can you rebase this so it passes?

Sure. On it.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

Some action results are stuck because ubuntu-16.04 is no longer available. I'm merging as-is and hope the merge of #83 will solve these issues in main.

@paulo-ferraz-oliveira paulo-ferraz-oliveira merged commit 3250a83 into erlef:main Jan 12, 2022
@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the feature/scheduled-3rd-party-license-updates branch January 12, 2022 11:40
@paulo-ferraz-oliveira
Copy link
Collaborator Author

https://github.com/erlef/setup-beam/actions/runs/1687446824 ran and didn't update anything. 😄 I assume it's because there's really nothing to update - we've updated the licenses very recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build is failing per third-party license differences
2 participants
0