Allow for latest 100 rebar3 versions when fetching from GitHub #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,13 +20,13 @@ jobs: | |||
| node-version: '12' | |||
| - run: npm install -g npm | |||
| - run: npm install | |||
| - run: npm run format | |||
There was a problem hiding this comment.
I added this change here so I don't have to deal with build after format stopping my CI midway through.
.github/workflows/test.yml
Outdated
| @@ -32,6 +32,7 @@ jobs: | |||
| combo: | |||
| - elixir-version: 'v1.0' | |||
| otp-version: '17' | |||
| rebar3-version: '3.6.0' | |||
There was a problem hiding this comment.
As per what was actually failing for @wojtekmach.
|
Tests are failing because versions I didn't consider would move forward just moved forward due to the |
| @@ -56,7 +56,7 @@ jobs: | |||
| os: 'ubuntu-16.04' | |||
| - elixir-version: 'v1.4' | |||
| otp-version: '20' | |||
| rebar3-version: '3.11' | |||
| rebar3-version: '3.6.0' | |||
There was a problem hiding this comment.
Good'ol trial-and-error.
wojtekmach
approved these changes
May 27, 2021
|
@starbelly, wanna give this a quick looksy? |
starbelly
approved these changes
May 27, 2021
|
@paulo-ferraz-oliveira Yup, did earlier, merge away, tag away. Edit: I'll take care of merging and tagging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40.
Also closes #39.
Edit: after this one's approved and merged we could think about 1.7.2, since there's also a recent patch by @wojtekmach in the queue.