8000 Gracefully handle required missing retire arguments by starbelly · Pull Request #254 · erlef/rebar3_hex · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Gracefully handle required missing retire arguments #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 5, 2021
Merged

Gracefully handle required missing retire arguments #254

merged 2 commits into from
Jul 5, 2021

Conversation

starbelly
Copy link
Member

Closes #253

  • Add helper function in rebar3_hex_retire that gets a required param or raises
  • add basic tests for retire in integration suite
  • add post retirement route support in hex api model

@starbelly
Gracefully handle required missing retire arguments
3e4ab18 
- Add helper function in rebar3_hex_retire that gets a required param or raises
- add basic tests for retire in integration suite
- add post retirement route support in hex api model
@starbelly starbelly requested a review from tsloughter July 4, 2021 23:14
@starbelly @paulo-ferraz-oliveira
Update test/support/hex_api_model.erl
23fa397 
Co-authored-by: Paulo F. Oliveira <paulo.ferraz.oliveira@gmail.com>
@starbelly starbelly merged commit 4de326b into erlef:master Jul 5, 2021
starbelly added a commit to starbelly/rebar3_hex that referenced this pull request Jul 5, 2021
@starbelly @paulo-ferraz-oliveira
Gracefully handle required missing retire arguments (erlef#254)
246ce2a 
* Gracefully handle required missing retire arguments

- Add helper function in rebar3_hex_retire that gets a required param or raises
- add basic tests for retire in integration suite
- add post retirement route support in hex api model

Co-authored-by: Paulo F. Oliveira <paulo.ferraz.oliveira@gmail.com>
@oubiwann
Copy link

Any chance of a point release with this fix in it? :-D

starbelly added a commit that referenced this pull request Jul 11, 2021
@starbelly @paulo-ferraz-oliveira
Gracefully handle required missing retire arguments (#254)
485019a 
* Gracefully handle required missing retire arguments

- Add helper function in rebar3_hex_retire that gets a required param or raises
- add basic tests for retire in integration suite
- add post retirement route support in hex api model

Co-authored-by: Paulo F. Oliveira <paulo.ferraz.oliveira@gmail.com>
@starbelly
Copy link
Member Author

@oubiwann Yup, v6.11.6 released.

@starbelly starbelly deleted the case_get_required branch December 24, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulo-ferraz-oliveira paulo-ferraz-oliveira paulo-ferraz-oliveira approved these changes

@tsloughter tsloughter Awaiting requested review from tsloughter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error on 'retire' command
3 participants
@starbelly @oubiwann @paulo-ferraz-oliveira
0