implement mib_first_files support in rebar_compiler_mib #1969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you include the commits from #1967 in this PR so that they can be reviewed together? It will make it easier to compare what the code validates with the rest. |
fbbc209 to
c32d832
Compare
|
i will investigate the failing test on OTP 17 and OTP 18. |
consider A-MIB imports from B-MIB: rebar compile MUST FAIL if mib_first_files is ["mibs/A-MIB.mib"] rebar compile MUST SUCCEED if mib_first_files is ["mibs/B-MIB.mib"]
mostly copy/paste from rebar_compiler_erl
c32d832 to
079216c
Compare
|
fixed test for OTP 17 and OTP 18 (mib compiler was not happy about the Integer TEXTUAL-CONVENTION in the test data) |
tsloughter
approved these changes
Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mostly copy/paste from rebar_compiler_erl
fix #1968