8000 ci: fix clang tidy after PR 2829 by canepat · Pull Request #2799 · erigontech/silkworm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ci: fix clang tidy after PR 2829 #2799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 24, 2025
Merged

ci: fix clang tidy after PR 2829 #2799

merged 15 commits into from
Apr 24, 2025

Conversation

canepat
Copy link
Member
@canepat canepat commented Mar 18, 2025

No description provided.

@canepat canepat force-pushed the ci/fix_clang_tidy_after_2769 branch from 1cfb149 to e436224 Compare March 18, 2025 21:01
battlmonstr
battlmonstr approved these changes Mar 20, 2025
View reviewed changes
@canepat canepat force-pushed the ci/fix_clang_tidy_after_2769 branch from e436224 to b3478bb Compare April 22, 2025 14:25
@canepat canepat force-pushed the ci/fix_clang_tidy_after_2769 branch from 3f46d9c to ad981fe Compare April 22, 2025 15:28
@codecov Codecov
Copy link
codecov bot commented Apr 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 17.64706% with 28 lines in your changes missing coverage. Please review.

Project coverage is 49.97%. Comparing base (7f02b78) to head (78ec55e).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
silkworm/db/datastore/common/ranges/if_view.hpp 0.00% 6 Missing ⚠️
.../db/datastore/kvdb/history_range_by_keys_query.hpp 0.00% 3 Missing ⚠️
...atastore/snapshots/history_range_by_keys_query.hpp 0.00% 3 Missing ⚠️
silkworm/rpc/commands/ots_api.cpp 0.00% 3 Missing ⚠️
silkworm/rpc/http/deflater.hpp 0.00% 3 Missing ⚠️
silkworm/db/datastore/common/ranges/merge_view.hpp 0.00% 2 Missing ⚠️
...b/datastore/kvdb/history_range_in_period_query.hpp 0.00% 1 Missing ⚠️
...astore/snapshots/history_range_in_period_query.hpp 0.00% 1 Missing ⚠️
silkworm/infra/common/log.cpp 50.00% 0 Missing and 1 partial ⚠️
silkworm/rpc/commands/eth_api.cpp 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2799      +/-   ##
==========================================
- Coverage   50.01%   49.97%   -0.04%     
==========================================
  Files         837      837              
  Lines       54799    54792       -7     
  Branches     8484     8484              
==========================================
- Hits        27406    27384      -22     
- Misses      25004    25026      +22     
+ Partials     2389     2382       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@canepat canepat changed the title ci: fix clang tidy after PR 2769 ci: fix clang tidy after PR 2829 Apr 24, 2025
@canepat canepat marked this pull request as ready for review April 24, 2025 08:39
@canepat canepat merged commit 43a6c01 into master Apr 24, 2025
17 of 18 checks passed
@canepat canepat deleted the ci/fix_clang_tidy_after_2769 branch April 24, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@battlmonstr battlmonstr battlmonstr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@canepat @battlmonstr
0