[Bugfix] Destroy operator when run finishes #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukritkalra
added a commit
that referenced
this pull request
Jan 26, 2022
* Invoke destroy when sources finish running (#152) * Rust linq operators * reordered imports * removing unused imports * Delete operator_executor.rs * cleaning up traits and renaming files * more format cleanup * changes after review * fixed operator names * cleaned up comment * Use where clauses for types and fix imports in linq.rs * Fix SourceOp in linq.rs to take in OperatorConfig Co-authored-by: Peter Schafhalter <pschafhalter@berkeley.edu> Co-authored-by: Sukrit Kalra <sukritkalra@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in operators with no input streams where
destroy()would not be invoked afterrun()finishes.Note: although
destroy()will be invoked, top watermarks are not automatically sent on output streams.