8000 Fix warning for Algolia SSR with React 18 · Issue #1114 · equinor/energyvision · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning for Algolia SSR with React 18 #1114

Closed
wenche opened this issue May 25, 2022 · 5 comments
Closed

Fix warning for Algolia SSR with React 18 #1114

wenche opened this issue May 25, 2022 · 5 comments
Assignees
@fernandolucchesi
Labels
🚀 ready to deploy Use this if issue is ready to be deployed 🛠 Technical Technical stuffs like reducing debt, refactor or improve code base

Comments

@wenche
Copy link
Contributor
wenche commented May 25, 2022 •
edited
Loading

Skjermbilde 2022-05-25 kl. 10.31.53.png
@wenche wenche self-assigned this May 25, 2022
@wenche
Copy link
Contributor Author
wenche commented May 25, 2022

I'm unfortunately not able to fix this easily. It also seems to be related to a reported issue at the Algolia repo. The code seems to work fine even with the warning, and the warning is only visible server side, so it will be visible in our Radix logs for the newsroom.

My suggestion will be to move this to Dependent on others column, and see if Algolia is able to sort this out. In the meantime, I have changed the code to use react-instantsearch-hooks-web instead of react-instantsearch-hook as the newly documented Algolia examples suggest. The main difference is that the web library includes the work in progress React components along with the hooks, so it will create a better foundation for using Algolia components when we continue the work for the newsroom. :)

@wenche wenche added the 🛠 Technical Technical stuffs like reducing debt, refactor or improve code base label May 30, 2022
@SvSven
Copy link
Contributor
SvSven commented Oct 17, 2022

This is an issue with React 18 and hasn't been fixed upstream yet:

algolia/instantsearch#5243

facebook/react#22796

Don't think there's anything we can do on our end with this yet - but it shouldn't cause any issues to have the warning.

@nilsml
Copy link
Contributor
nilsml commented May 2, 2023

Any news about this one @SvSven ?

@nilsml
Copy link
Contributor
nilsml commented Sep 20, 2023

Someone should have a look to see if it is already fixed

@fernandolucchesi
Copy link
Contributor

[InstantSearch] The package react-instantsearch-hooks is replaced by react-instantsearch-core. The API is the same, but the package name has changed. Please update your dependencies and follow the migration guide: https://www.algolia.com/doc/guides/building-search-ui/upgrade-guides/react/
[InstantSearch] The package react-instantsearch-hooks-router-nextjs is replaced by react-instantsearch-router-nextjs. The API is the same, but the package name has changed. Please update your dependencies and follow the migration guide: https://www.algolia.com/doc/guides/building-search-ui/upgrade-guides/react/
[InstantSearch] The package react-instantsearch-hooks-server is replaced by react-instantsearch. The API is the same, but the package name has changed. Please update your dependencies and follow the migration guide: https://www.algolia.com/doc/guides/building-search-ui/upgrade-guides/react/
[InstantSearch] The package react-instantsearch-hooks-web is replaced by react-instantsearch. The API is the same, but the package name has changed. Please update your dependencies and follow the migration guide: https://www.algolia.com/doc/guides/building-search-ui/upgrade-guides/react/

fernandolucchesi added a commit that referenced this issue Nov 15, 2023
@fernandolucchesi
♻️ Refactor instant search packages and remove warnings #1114
8b8d92c
fernandolucchesi added a commit that referenced this issue Nov 17, 2023
@fernandolucchesi
♻️ Refactor instant search packages and remove warnings #1114 (#1978)
96ec4dc
@fernandolucchesi fernandolucchesi added the 🚀 ready to deploy Use this if issue is ready to be deployed label Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fernandolucchesi fernandolucchesi

Labels
🚀 ready to deploy Use this if issue is ready to be deployed 🛠 Technical Technical stuffs like reducing debt, refactor or improve code base
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wenche @nilsml @SvSven @fernandolucchesi
0